[stable31] fix(sharing): Adapt share suggestions to match trusted servers configs #55643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
approved these changes
Oct 10, 2025
nfebe
requested changes
Oct 10, 2025
Contributor
nfebe
left a comment
nfebe
left a comment
There was a problem hiding this comment.
Requires update, backport incomplete.
Contributor
|
Requires : #55893 |
nfebe
approved these changes
Nov 11, 2025
nfebe
force-pushed
the
backport/55080/stable31
branch
from
79a089e to
8574a0a
Compare
When `show_federated_shares_to_trusted_servers_as_internal` is enabled but `show_federated_shares_as_internal` is not, filter federated share suggestions to only include trusted servers. Previously, searching for an email address would suggest non-trusted federated servers. Resolved: #54511 Signed-off-by: nfebe <[email protected]>
Signed-off-by: nfebe <[email protected]> [skip ci]
The federation app is not always installed, causing errors when TrustedServers is injected as a hard dependency. This change makes the dependency optional by using nullable types and null-safe operators, defaulting to false when unavailable. Modified backport of #55893 which are required for the stable31 backport to function correctly. Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
backport/55080/stable31
branch
from
8574a0a to
6a1fdf5
Compare
Contributor
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #55080
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.